I replaced an old metal pipe and p-trap with 2 inch PVC for a shower drain. I was only able to fit the new pvc p-trap if I made a loop-de-loop. Is this a good solution?
It looks like you have a double trap, unless I'm mistaken on how the water flows through this drain.
I've scribbled in where water will sit in the pipe, which clearly shows two traps.
The best option would be to go from the upper 90 of the P-trap, directly into the outlet pipe.
When you rebuild the trap, you should use a u-bend with a cleanout.